Reenable Install and Snapshotter Testing #9601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
approved these changes
Feb 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9601 +/- ##
==========================================
- Coverage 49.32% 39.48% -9.84%
==========================================
Files 154 151 -3
Lines 13523 13471 -52
==========================================
- Hits 6670 5319 -1351
- Misses 5609 6995 +1386
+ Partials 1244 1157 -87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vitorsavian
approved these changes
Mar 1, 2024
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Mar 4, 2024
* Use regular ubuntu runners for install and snapshotter tests * Workaround for vagrant box caching * Update testing readme Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Mar 4, 2024
* Use regular ubuntu runners for install and snapshotter tests * Workaround for vagrant box caching * Update testing readme Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Mar 4, 2024
* Use regular ubuntu runners for install and snapshotter tests * Workaround for vagrant box caching * Update testing readme Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Mar 4, 2024
* Use regular ubuntu runners for install and snapshotter tests * Workaround for vagrant box caching * Update testing readme Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Mar 5, 2024
* Use regular ubuntu runners for install and snapshotter tests * Workaround for vagrant box caching * Update testing readme Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Mar 5, 2024
* Use regular ubuntu runners for install and snapshotter tests * Workaround for vagrant box caching * Update testing readme Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
CI and Testing
Verification
See dereknola#19, which has the install and snapshotter GH workflows enabled. I do not want to reenable them on K3s-io until this PR is merged, as other PRs will start running the workflows and fail.
Linked Issues
#8591
User-Facing Change
Further Comments